Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ (spikes): Add lk_led_ #473

Merged
merged 1 commit into from
Jan 31, 2022
Merged

✨ (spikes): Add lk_led_ #473

merged 1 commit into from
Jan 31, 2022
+92 −0

Conversation

HPezz
Copy link
Contributor

@HPezz HPezz commented Jan 28, 2022

Create a spike lk_led tthat does not use FastLED but CoreLED instead.

@codecov
Copy link

codecov bot commented Jan 28, 2022 •
edited
Loading

Codecov Report

Merging #473 (d445df0) into develop (a95edef) will not change coverage.
The diff coverage is n/a.

❗ Current head d445df0 differs from pull request most recent head d26ea7e. Consider uploading reports for the commit d26ea7e to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##           develop      #473   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           76        76           
  Lines         1262      1262           
=========================================
  Hits          1262      1262

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a95edef...d26ea7e. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jan 28, 2022 •
edited
Loading

File comparision analysis report

🔖 Info

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ✅ ✅ 63816 (3%) ø 12184 (2%) ø
bootloader ✔️ ✅ ✅ 95272 (4%) ø 26792 (5%) ø
certs_emc_ble_bt_lcd_led_motors ✔️ ✅ ✅ 249184 (11%) ø 29240 (5%) ø
certs_emc_ble_led_motors ✔️ ✅ ✅ 174568 (8%) ø 24952 (4%) ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi ✔️ ✅ ✅ 148840 (7%) ø 22528 (4%) ø
certs_emc_lcd_led_motors ✔️ ✅ ✅ 91928 (4%) ø 16168 (3%) ø
hardware_motors_test_reduction_and_wheels ✔️ ✅ ✅ 177960 (8%) ø 24360 (4%) ø
spike_lk_ble ✔️ ✅ ✅ 156328 (7%) ø 22984 (4%) ø
spike_lk_bluetooth ✔️ ✅ ✅ 73256 (3%) ø 11448 (2%) ø
spike_lk_cg_animations ✔️ ✅ ✅ 141112 (6%) ø 24464 (4%) ø
spike_lk_coreled ✨ - - 74788 (3%) - 13616 (2%) -
spike_lk_file_reception ✔️ ✅ ✅ 328916 (15%) ø 19312 (3%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 63880 (3%) ø 11448 (2%) ø
spike_lk_lcd ✔️ ✅ ✅ 136976 (6%) ø 24024 (4%) ø
spike_lk_led ✔️ ✅ ✅ 65744 (3%) ø 13392 (2%) ø
spike_lk_log_kit ✔️ ✅ ✅ 68528 (3%) ø 11912 (2%) ø
spike_lk_motors ✔️ ✅ ✅ 62528 (2%) ø 11488 (2%) ø
spike_lk_rfid ✔️ ✅ ✅ 73072 (3%) ø 11448 (2%) ø
spike_lk_sensors_battery ✔️ ✅ ✅ 63072 (3%) ø 11984 (2%) ø
spike_lk_sensors_light ✔️ ✅ ✅ 60056 (2%) ø 11440 (2%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 72496 (3%) ø 11504 (2%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 66968 (3%) ø 11424 (2%) ø
spike_lk_sensors_touch ✔️ ✅ ✅ 68600 (3%) ø 11432 (2%) ø
spike_lk_ticker_timeout ✔️ ✅ ✅ 69052 (3%) ø 11632 (2%) ø
spike_lk_update_process_app_base ✔️ ✅ ✅ 121348 (5%) ø 15288 (2%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 77632 (3%) ø 12352 (2%) ø
spike_lk_wifi ✔️ ✅ ✅ 116392 (5%) ø 14808 (2%) ø
spike_mbed_blinky ✔️ ✅ ✅ 57968 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 63208 (3%) ø 12448 (2%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 58456 (2%) ø 11400 (2%) ø

🗺️ Map files diff output

Click to show diff list
spike_lk_coreled (click to expand) 


Flash used: 74788&nbsp;(3%) / total: 2097152
SRAM used: 13616&nbsp;(2%) / total: 524288

@github-actions
Copy link

github-actions bot commented Jan 28, 2022 •
edited
Loading

File comparision analysis report

🔖 Info

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ✅ ✅ 87456 (4%) ø 18248 (3%) ø
bootloader ✔️ ✅ ✅ 95272 (4%) ø 26792 (5%) ø
certs_emc_ble_bt_lcd_led_motors ✔️ ✅ ✅ 256728 (12%) ø 35272 (6%) ø
certs_emc_ble_led_motors ✔️ ✅ ✅ 191600 (9%) ø 30976 (5%) ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi ✔️ ✅ ✅ 165248 (7%) ø 28680 (5%) ø
certs_emc_lcd_led_motors ✔️ ✅ ✅ 91928 (4%) ø 16168 (3%) ø
hardware_motors_test_reduction_and_wheels ✔️ ✅ ✅ 194032 (9%) ø 30384 (5%) ø
spike_lk_ble ✔️ ✅ ✅ 175376 (8%) ø 28976 (5%) ø
spike_lk_bluetooth ✔️ ✅ ✅ 91192 (4%) ø 17472 (3%) ø
spike_lk_cg_animations ✔️ ✅ ✅ 149384 (7%) ø 30464 (5%) ø
spike_lk_coreled ✨ - - 87164 (4%) - 19560 (3%) -
spike_lk_file_reception ✔️ ✅ ✅ 333692 (15%) ø 25272 (4%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 87352 (4%) ø 17512 (3%) ø
spike_lk_lcd ✔️ ✅ ✅ 149792 (7%) ø 30096 (5%) ø
spike_lk_led ✔️ ✅ ✅ 88808 (4%) ø 19400 (3%) ø
spike_lk_log_kit ✔️ ✅ ✅ 92000 (4%) ø 18168 (3%) ø
spike_lk_motors ✔️ ✅ ✅ 86576 (4%) ø 17552 (3%) ø
spike_lk_rfid ✔️ ✅ ✅ 91008 (4%) ø 17472 (3%) ø
spike_lk_sensors_battery ✔️ ✅ ✅ 86744 (4%) ø 18056 (3%) ø
spike_lk_sensors_light ✔️ ✅ ✅ 84584 (4%) ø 17512 (3%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 85336 (4%) ø 17512 (3%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 90896 (4%) ø 17496 (3%) ø
spike_lk_sensors_touch ✔️ ✅ ✅ 92248 (4%) ø 17632 (3%) ø
spike_lk_ticker_timeout ✔️ ✅ ✅ 83224 (3%) ø 17592 (3%) ø
spike_lk_update_process_app_base ✔️ ✅ ✅ 143764 (6%) ø 21352 (4%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 100968 (4%) ø 18472 (3%) ø
spike_lk_wifi ✔️ ✅ ✅ 131280 (6%) ø 20832 (3%) ø
spike_mbed_blinky ✔️ ✅ ✅ 57968 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 84688 (4%) ø 18448 (3%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 84000 (4%) ø 17536 (3%) ø

🗺️ Map files diff output

Click to show diff list
spike_lk_coreled (click to expand) 


Flash used: 87164&nbsp;(4%) / total: 2097152
SRAM used: 19560&nbsp;(3%) / total: 524288

@HPezz HPezz force-pushed the hugo/feature/Add-lk_led-spike-without-FastLED branch from 7c21597 to 9ef1a00 Compare January 28, 2022 16:56
ladislas
ladislas requested changes Jan 30, 2022
View reviewed changes
Copy link
Member

@ladislas ladislas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

premier passage! 👍

spikes/CMakeLists.txt Outdated Show resolved Hide resolved
spikes/lk_led_/main.cpp Outdated Show resolved Hide resolved
spikes/lk_led_/main.cpp Outdated Show resolved Hide resolved
spikes/lk_led_/main.cpp Outdated Show resolved Hide resolved
spikes/lk_led_/main.cpp Outdated Show resolved Hide resolved
spikes/lk_led_/main.cpp Outdated Show resolved Hide resolved
@HPezz HPezz force-pushed the hugo/feature/Add-lk_led-spike-without-FastLED branch 2 times, most recently from ae94f7e to 97b9a02 Compare January 31, 2022 09:31
@HPezz HPezz requested a review from ladislas January 31, 2022 09:39
@HPezz HPezz force-pushed the hugo/feature/Add-lk_led-spike-without-FastLED branch from 97b9a02 to a4edb75 Compare January 31, 2022 11:07
@HPezz @ladislas
✨ (spikes): Add lk_coreled spike
d26ea7e 
Test the CoreLED library as a replacement of FastLED.
@ladislas ladislas force-pushed the hugo/feature/Add-lk_led-spike-without-FastLED branch from d445df0 to d26ea7e Compare January 31, 2022 14:05
@ladislas ladislas merged commit ecbaeb1 into develop Jan 31, 2022
@ladislas ladislas deleted the hugo/feature/Add-lk_led-spike-without-FastLED branch January 31, 2022 14:09
@sonarcloud
Copy link

sonarcloud bot commented Jan 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YannLocatelli YannLocatelli YannLocatelli left review comments

@ladislas ladislas Awaiting requested review from ladislas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HPezz @ladislas @YannLocatelli